Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETPROD-3585] Optimised fetching certificates by name #1115

Merged
merged 7 commits into from
Feb 29, 2024
Merged

[NETPROD-3585] Optimised fetching certificates by name #1115

merged 7 commits into from
Feb 29, 2024

Conversation

guptado
Copy link
Contributor

@guptado guptado commented Feb 27, 2024 •
edited by jira bot
Loading

apinonformoso
apinonformoso reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@apinonformoso apinonformoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the changes be tested locally apart from the unit tests?

andrewsomething
andrewsomething approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething merged commit f1c7d18 into main Feb 29, 2024
3 checks passed
@andrewsomething andrewsomething deleted the NETPROD-3585/addNameFilterCertificates branch February 29, 2024 19:44
@andrewsomething andrewsomething mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apinonformoso apinonformoso apinonformoso left review comments

@avyas-digitalocean avyas-digitalocean avyas-digitalocean left review comments

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guptado @andrewsomething @avyas-digitalocean @apinonformoso